Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCO-324: Unrevert "CCO-324: add support for workload identity" #83

Merged
merged 2 commits into from
Jun 28, 2023
Merged

CCO-324: Unrevert "CCO-324: add support for workload identity" #83

merged 2 commits into from
Jun 28, 2023

Conversation

bertinatto
Copy link
Member

CC @openshift/storage

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 26, 2023 •
edited by openshift-ci bot

@bertinatto: This pull request references CCO-324 which is a valid jira issue.

In response to this:

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member Author

/hold
until this is properly tested

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@openshift-ci openshift-ci bot requested review from dobsonj and jsafrane June 26, 2023 16:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@bertinatto bertinatto force-pushed the bring-workload-identity-back branch from 2ef4515 to 7e8be5d Compare June 26, 2023 16:53
@bertinatto
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

@bertinatto: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c74d19e0-1442-11ee-9b73-abf4cc295c20-0

@bertinatto bertinatto force-pushed the bring-workload-identity-back branch from 7e8be5d to 4037557 Compare June 27, 2023 14:21
@bertinatto
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@bertinatto: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/58ba7f10-14fe-11ee-8df8-f7a894546070-0

@bertinatto bertinatto force-pushed the bring-workload-identity-back branch 2 times, most recently from 9f18564 to d47f118 Compare June 27, 2023 16:32
@bertinatto
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@bertinatto: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/414aaaa0-150b-11ee-92db-d1c0c10047ec-0

@bertinatto
Copy link
Member Author

/retest-required

@bertinatto
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@bertinatto: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-sdn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/926063d0-1533-11ee-97f9-1d354d279190-0

@bertinatto
Copy link
Member Author

/test e2e-azure

@bertinatto
Copy link
Member Author

/test e2e-azure-csi-extended

@bertinatto bertinatto force-pushed the bring-workload-identity-back branch from d47f118 to 7fbfb17 Compare June 28, 2023 11:47
@bertinatto
Copy link
Member Author

/retest-required

@bertinatto
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack-csi 7fbfb17 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Jun 28, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, gnufied

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 09e2b6c into openshift:master Jun 28, 2023
7 of 8 checks passed
@duanwei33
Copy link

See pre-merge test result in https://issues.redhat.com/browse/STOR-1319.

@duanwei33
Copy link

Also enabling TechPreviewNoUpgrade will not break the storage CO with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@gnufied gnufied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bertinatto @openshift-ci-robot @gnufied @duanwei33 @openshift-merge-robot